Re: [PATCH 06/19] perf ftrace: Add support for --pid option

[David Ahern]

On 6/26/13 1:14 AM, Namhyung Kim wrote:
> @@ -196,6 +222,8 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused)
>   	const struct option ftrace_options[] = {
>   	OPT_STRING('t', "tracer", &ftrace.tracer, "tracer",
>   		   "tracer to use"),
> +	OPT_STRING('p', "pid", &ftrace.target.tid, "pid",
> +		   "trace on existing process id"),
>   	OPT_INCR('v', "verbose", &verbose,
>   		 "be more verbose"),
>   	OPT_END()

You are calling it pid but assigning it as a tid which is inconsistent 
with other perf commands. e.g., perf-record allows a list of pids (-p) 
or tids (-t). Why not support that in perf-ftrace? And that leads to the 
comment about consistency of options across perf commands: -t is used 
here for tracer type to use.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/