Re: [PATCH 12/15] perf tools: allow non-matching sample types

[Stephane Eranian]

On Wed, Jun 26, 2013 at 11:00 PM, David Ahern <dsahern@xxxxxxxxx> wrote:
> On 6/26/13 2:54 PM, Stephane Eranian wrote:
>>
>> On Wed, Jun 26, 2013 at 10:48 PM, David Ahern <dsahern@xxxxxxxxx> wrote:
>>>
>>> Arnaldo:
>>>
>>> I noticed this patch in your perf/core branch. I do not think this one is
>>> ready to be committed. It does not fully solve the problem of allowing
>>> non-matching sample types.
>>>
>>> I have a set of patches here on github that work fine for one use case --
>>> mixed s/w and tracepoint events:
>>> https://github.com/dsahern/linux/tree/multiple-sample_type
>>>
>>> I'll push the patches out, but wanted to run some more test cases first.
>>>
>> All those solutions address the need of perf but they do not fix the
>> fundamental
>> problem that the kernel is exporting a un-parseable file in case of
>> different
>> sample_type for each event. We need to fix the generic case so that other
>> tools don't have to deal with this. I will post a patch which can solve
>> this
>> in the kernel and yet remain backward compatible. But I don't  have the
>> perf portion of the patch, hoping somebody can help with developing it.
>
>
> The patchset in the URL above attempts to find the id which correlates to
> the evsel which has the sample_type. It starts at the max index (IP, TID,
> TIME and ADDR all requested which means an index of 4 for the ID) and then
> works its way in (meaning one of the above is not requested).
>
But you realize that imposing this kind of iterative search on all the tools
is not very good. it probably solves it for perf and the way perf tracks
the  per-event info, but they ought to be something simpler to do.


> Would be better for the event sample to put the id at the front or the
> sample_type at the front, but that ship has sailed. It would be nice to have
> a userspace option that works with existing kernels.
>
> I'll take a look at your kernel change when you post it to see what I am
> overlooking here but the patches have worked fine for me so far.
>
> David
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/