Re: [PATCH 06/15] perf tools: fix parse_events_terms() freeing localvariable on error path

[Adrian Hunter]

On 25/06/13 16:13, Jiri Olsa wrote:
> On Mon, Jun 24, 2013 at 04:16:03PM +0300, Adrian Hunter wrote:
>> The list_head is on the stack, so just free the rest of the list.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>> ---
>>  tools/perf/util/pmu.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
>> index 4c6f9c4..def64d4 100644
>> --- a/tools/perf/util/pmu.c
>> +++ b/tools/perf/util/pmu.c
>> @@ -194,7 +194,8 @@ static int pmu_alias_terms(struct perf_pmu_alias *alias,
>>  	list_for_each_entry(term, &alias->terms, list) {
>>  		ret = parse_events_term__clone(&clone, term);
>>  		if (ret) {
>> -			parse_events__free_terms(&list);
>> +			list_for_each_entry_safe(term, clone, &list, list)
>> +				free(term);
> 
> Could you please add __parse_events__free_terms doing this
> and being called from parse_events__free_terms as you did
> for __perf_evlist__munmap in the other patch.

Thanks for reviewing.  Fixed in V2.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/