Re: [PATCH 05/19] perf tools: Introduce new 'ftrace' tool

[David Ahern]

On 6/26/13 11:04 PM, Namhyung Kim wrote:
> Hi David,
>
> On Wed, 26 Jun 2013 11:10:34 -0600, David Ahern wrote:
> > On 6/26/13 1:14 AM, Namhyung Kim wrote:
> > > +	const char * const ftrace_usage[] = {
> > > +		"perf ftrace [<options>] [<command>]",
> > > +		"perf ftrace [<options>] -- <command> [<options>]",
> > > +		NULL
> > > +	};
> > > +	const struct option ftrace_options[] = {
> > > +	OPT_STRING('t', "tracer", &ftrace.tracer, "tracer",
> > > +		   "tracer to use"),
> >
> > How does a user know what is a valid tracer string?
>
> The helpline should look like (at least):
>
>    "tracer to use: function_graph or function"

exactly. I would suggest making that OPT_CALLBACK as well to validate 
the string content when options are parsed.

David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/