Re: od_set_powersave_bias: NULL pointer dereference

[Viresh Kumar]

On 27 June 2013 20:39, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 27 June 2013 20:25, Jacob Shin <jacob.shin@xxxxxxx> wrote:
>> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
>> index 4b9bb5d..93eb5cb 100644
>> --- a/drivers/cpufreq/cpufreq_ondemand.c
>> +++ b/drivers/cpufreq/cpufreq_ondemand.c
>> @@ -47,6 +47,8 @@ static struct od_ops od_ops;
>>  static struct cpufreq_governor cpufreq_gov_ondemand;
>>  #endif
>>
>> +static unsigned int default_powersave_bias;
>
> Because you haven't replied to my earlier comment on this, I
> thought you agreed. But it looks you haven't read my first
> reply well.

BTW, your v1 is already applied and sent to Linus. So,
you need to send only fixup now.

But, you still need to answer why you need
default_powersave_bias? And if it is not a must then should be
removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/