Re: mmotm 2013-06-27-16-36 uploaded (wait event common)

[Oleg Nesterov]

On 06/29, Valdis.Kletnieks@xxxxxx wrote:
>
> On Thu, 27 Jun 2013 22:30:41 -0700, Randy Dunlap said:
>
> > +		__ret = __wait_no_timeout(tout) ?: (tout) ?: 1;
>
> Was this trying to do a  wait_ho_timeout(!!tout)  or something?

No, __wait_no_timeout() means that tout == MAX_SCHEDULE_TIMEOUT.
But the logic is wrong, we should return zero in this case.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/