Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

From: ZhenHua
Date: Sun Jun 30 2013 - 21:13:06 EST


On 06/28/2013 10:22 PM, Alan Stern wrote:
On Fri, 28 Jun 2013, Li, Zhen-Hua (USL-China) wrote:

There was a problem, the warning "Controller not stopped yet".
And your last patch for this problem does a wrong thing:
It prevents all HP uhci devices from auto-stop, which make HP uhci
devices waste more
power.
Do they really waste more power? Have you measured this?

Is CONFIG_PM enabled in the kernel configuration?

This is another new problem.

I think this should be corrected, so I want to apply it.
In the last email, you said that your patch did not make the machine
act different. Now you say that your patch makes the machine use less
power. Which statement is correct?

Alan Stern

Let's make it clear:
I said "I don't have a machine that this makes action different",
it does not mean my patch "did not make the machine act different ".

There are many kinds of machines, I have never said "my patch does
not make ALL of them act different".




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/