Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap
From: Mark Brown
Date: Thu Jul 04 2013 - 06:45:49 EST
On Thu, Jul 04, 2013 at 11:02:41AM +0200, Sebastian Andrzej Siewior wrote:
> The driver here does not use atomic updates but read followed by write
> so your locking here is futile. So the API/regmap alone does not make
Doesn't that sound like the driver ought to be using a r/m/w primitive
though?
> it right. And look: the MFD part uses regmap. Its children (IIO &
> input) do not use it. After I told this Samuel he said that it is okay.
Again I think the point here was that they probably ought to do so.
But I guess if you're saying there's no problem that's fine...
Attachment:
signature.asc
Description: Digital signature