RE: [PATCH] drivers/net: enic: release rtnl_lock on error-path

From: Neel Patel (neepatel)
Date: Mon Jul 08 2013 - 12:36:40 EST

Looks good.

Thanks!

-----Original Message-----
From: Nishank Trivedi (nistrive)
Sent: Monday, July 08, 2013 9:26 AM
To: Konstantin Khlebnikov
Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Neel Patel (neepatel); Christian Benvenuti (benve)
Subject: Re: [PATCH] drivers/net: enic: release rtnl_lock on error-path

On 7/8/13 12:22 AM, Konstantin Khlebnikov wrote:
> enic_change_mtu_work() must call rtnl_unlock() on all exiting paths.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
> Cc: Christian Benvenuti <benve@xxxxxxxxx>
> Cc: Roopa Prabhu <roprabhu@xxxxxxxxx>
> Cc: Neel Patel <neepatel@xxxxxxxxx>
> Cc: Nishank Trivedi <nistrive@xxxxxxxxx>
> ---
> drivers/net/ethernet/cisco/enic/enic_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index 635f559..992ec2e 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -1761,6 +1761,7 @@ static void enic_change_mtu_work(struct work_struct *work)
> enic_synchronize_irqs(enic);
> err = vnic_rq_disable(&enic->rq[0]);
> if (err) {
> + rtnl_unlock();
> netdev_err(netdev, "Unable to disable RQ.\n");
> return;
> }
> @@ -1773,6 +1774,7 @@ static void enic_change_mtu_work(struct work_struct *work)
> vnic_rq_fill(&enic->rq[0], enic_rq_alloc_buf);
> /* Need at least one buffer on ring to get going */
> if (vnic_rq_desc_used(&enic->rq[0]) == 0) {
> + rtnl_unlock();
> netdev_err(netdev, "Unable to alloc receive buffers.\n");
> return;
> }
>

Acked.

Thanks.
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—