Re: [PATCH] perf tools: Fixup for removing -f option in perf record

[Namhyung Kim]

Hi Arnaldo,

You may want to merge this patch too. :)

Thanks,
Namhyung


2013-06-27 ìí 1:25, Namhyung Kim ì ê:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> The commit bf3da4014a0c ("perf record: Remove -f/--force option") got
> rid of -f option from perf record.  But this option was used
> internally by various sub-commands so they wouldn't work anymore.
> Also update the example document not to use -f option.
>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
>   tools/perf/Documentation/examples.txt | 4 ++--
>   tools/perf/builtin-kmem.c             | 2 +-
>   tools/perf/builtin-lock.c             | 2 +-
>   tools/perf/builtin-sched.c            | 1 -
>   tools/perf/builtin-timechart.c        | 4 ++--
>   5 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/Documentation/examples.txt b/tools/perf/Documentation/examples.txt
> index 77f952762426..a4e392156488 100644
> --- a/tools/perf/Documentation/examples.txt
> +++ b/tools/perf/Documentation/examples.txt
> @@ -66,7 +66,7 @@ Furthermore, these tracepoints can be used to sample the workload as
>   well. For example the page allocations done by a 'git gc' can be
>   captured the following way:
>
> - titan:~/git> perf record -f -e kmem:mm_page_alloc -c 1 ./git gc
> + titan:~/git> perf record -e kmem:mm_page_alloc -c 1 ./git gc
>    Counting objects: 1148, done.
>    Delta compression using up to 2 threads.
>    Compressing objects: 100% (450/450), done.
> @@ -120,7 +120,7 @@ Furthermore, call-graph sampling can be done too, of page
>   allocations - to see precisely what kind of page allocations there
>   are:
>
> - titan:~/git> perf record -f -g -e kmem:mm_page_alloc -c 1 ./git gc
> + titan:~/git> perf record -g -e kmem:mm_page_alloc -c 1 ./git gc
>    Counting objects: 1148, done.
>    Delta compression using up to 2 threads.
>    Compressing objects: 100% (450/450), done.
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index 46878daca5cc..0259502638b4 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -708,7 +708,7 @@ static int parse_line_opt(const struct option *opt __maybe_unused,
>   static int __cmd_record(int argc, const char **argv)
>   {
>   	const char * const record_args[] = {
> -	"record", "-a", "-R", "-f", "-c", "1",
> +	"record", "-a", "-R", "-c", "1",
>   	"-e", "kmem:kmalloc",
>   	"-e", "kmem:kmalloc_node",
>   	"-e", "kmem:kfree",
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 425830069749..76543a4a7a30 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -878,7 +878,7 @@ static int __cmd_report(void)
>   static int __cmd_record(int argc, const char **argv)
>   {
>   	const char *record_args[] = {
> -		"record", "-R", "-f", "-m", "1024", "-c", "1",
> +		"record", "-R", "-m", "1024", "-c", "1",
>   	};
>   	unsigned int rec_argc, i, j;
>   	const char **rec_argv;
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 2da2a6ca22bf..fed9ae432c16 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1632,7 +1632,6 @@ static int __cmd_record(int argc, const char **argv)
>   		"record",
>   		"-a",
>   		"-R",
> -		"-f",
>   		"-m", "1024",
>   		"-c", "1",
>   		"-e", "sched:sched_switch",
> diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
> index ab4cf232b852..4536a92b18f3 100644
> --- a/tools/perf/builtin-timechart.c
> +++ b/tools/perf/builtin-timechart.c
> @@ -1005,7 +1005,7 @@ static int __cmd_record(int argc, const char **argv)
>   {
>   #ifdef SUPPORT_OLD_POWER_EVENTS
>   	const char * const record_old_args[] = {
> -		"record", "-a", "-R", "-f", "-c", "1",
> +		"record", "-a", "-R", "-c", "1",
>   		"-e", "power:power_start",
>   		"-e", "power:power_end",
>   		"-e", "power:power_frequency",
> @@ -1014,7 +1014,7 @@ static int __cmd_record(int argc, const char **argv)
>   	};
>   #endif
>   	const char * const record_new_args[] = {
> -		"record", "-a", "-R", "-f", "-c", "1",
> +		"record", "-a", "-R", "-c", "1",
>   		"-e", "power:cpu_frequency",
>   		"-e", "power:cpu_idle",
>   		"-e", "sched:sched_wakeup",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/