Re: [RFC PATCH] tracing/kprobe: Wait for disabling all runningkprobe handlers

[Peter Zijlstra]

On Tue, Jul 09, 2013 at 05:01:45PM +0900, Masami Hiramatsu wrote:
> +	if (wait) {
> +		/*
> +		 * synchronize with kprobe_trace_func/kretprobe_trace_func
> +		 * to ensure disabled (all running handlers are finished)
> +		 */
> +		synchronize_sched();
> +		kfree(link);	/* Ignored if link == NULL */
> +	}

What's not clear to me from this comment is if we're only waiting for kfree()?
In that case shouldn't we use call_rcu() to free the thing? Or do we need the
sync_sched() for other purposes as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/