Re: [PATCH V2] relay: fix timer madness

[Andrew Morton]

On Wed, 10 Jul 2013 11:37:26 +0800 Li Zefan <lizefan@xxxxxxxxxx> wrote:

> On 2013/7/10 10:18, zhangwei(Jovi) wrote:
> > When I'm using ktap script to tracing all event tracepoints by relay
> > transport, without this patch, the system will hang in few seconds.
> > 
> > I found the original patch discussion in 2007.
> > http://marc.info/?l=linux-kernel&m=118544794717162&w=2
> > (In that mail thread, the patch didn't fix that problem, but it fix
> > the problem I encountered now)
> > 
> > Changed from v1:
> > mod timer interval changed from jiffies+1 to HZ/10, as Ingo suggested.
> > 
> > Original patch changelog from Ingo in 2007:
> > 
> > Remove timer calls (!!!) from deep within the tracing infrastructure.
> > This was totally bogus code that can cause lockups and worse.
> > Poll the buffer every 2 jiffies for now.
> > 
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > Signed-off-by: "zhangwei(Jovi)" <jovi.zhangwei@xxxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
> I don't think this patch should have Andrew's signed-off-by?

I guess not, unless it was taken from -mm, which would be odd, as I
have the old version.

v1 has been in my tree for a few months - Ingo requested some updates
but nothing happened and I have not checked whether v2 addresses his
requests.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/