Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore

From: Laxman Dewangan
Date: Wed Jul 10 2013 - 02:55:24 EST


On Tuesday 09 July 2013 11:34 AM, Thierry Reding wrote:
* PGP Signed by an unknown key

On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
D
+
+ home {
+ label = "Home";
+ gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
+ linux,code = <102>; /* KEY_HOME */
I wonder if these should maybe go into a header file as well so that
symbolic names can be used. That'll make the value self-descriptive and
allow the comment to be dropped.

Currently there is no header for input.h in dt-binding include. We need to add them first and then use it.
Probably it can be done along with all cleanups on dts file atleast for Tegra.
I can start this if no one faster than me for this activity but for this patch, I like to go on legacy way.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/