Re: sched: add notifier for cross-cpu migrations

[Ingo Molnar]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Hi,
> 
> I just stumbled over commit 582b336ec2 and had a massive WTF moment.
> 
> The Changelog -- empty!
> The Implementation -- complete crap!
> 
> fail^2.
> 
> A git grep later I find its x86_64 paravirt only.. for this we add 
> unconditional crap to the scheduler?
> 
> At the _very_ least this should have been wrapped in a static_key and 
> the changelog should have given some clue as to the what and why of this 
> code.

My bad for letting it slip through...

Marcelo, mind implementing the suggestions from Peter?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/