Re: [PATCH 2/3] firmware/dmi_scan: Fix most checkpatch errors andwarnings

[Joe Perches]

On Wed, 2013-07-10 at 14:28 +0200, Jean Delvare wrote:
> Hi Joe,

hi Jean.

> Le Tuesday 09 July 2013 à 09:19 -0700, Joe Perches a écrit :
> > On Tue, 2013-07-09 at 17:42 +0200, Jean Delvare wrote:
[]
> > If the function name is used in every printk, it might
> > be better to add
> > #define pr_fmt(fmt) "%s: " fmt, __func__
[]
> > If not, then I suggest removing the embedded function names
> > and writing these as
> > 		pr_err("%s: etc...", __func__, etc...);
> > This eliminates any possible function name mismatch.
> I had considered this too, but stepped back after finding out that this
> change would increase the binary size. It's hard to sell such a change
> then when it's only fixing a theoretical problem.

No worries.

Another tiny consideration is that __func__ is both
generally not particularly useful and could in the
future be consolidated via vsprintf/printk having
some extension that uses __builtin_return_address
and sprint_symbol_no_offset.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/