Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

[Thierry Reding]

On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t30 cardhu.

Nit: "Tegra30 Cardhu"

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
[...]
>  				};
>  			};
>  		};
> +
> +		nct1008: nct1008 {

I don't think it's very likely that this chip will need to be referenced
by a phandle, in which case the "nct1008:" label can be dropped. Even if
it was used at some point in the future, it's better to add it at that
time.

Thierry

Attachment: signature.asc
Description: Digital signature