Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the newstreaming format
From: Borislav Petkov
Date: Wed Jul 10 2013 - 16:02:05 EST
On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote:
> Well, there's also no hand-holding when lzop is missing for LZO. And
> the error message is clear enough. No?
Actually, we should error out more gracefully than that. Maybe check for
the presence of the executable first and if not, exit out of the build
with an informational message that lz4c is not present on the system.
Ditto for lzop.
Currently, you wait for the whole build to complete just to see that
there's no executable at the end. Not nice.
> BTW speaking of introductory-level patches, what about the following
> one:
>
> Now that lz4 kernel compression is available, add *.lz4 to .gitignore
Yep. That makes sense.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/