Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

From: Oliver Schinagl
Date: Thu Jul 11 2013 - 07:16:09 EST


On 11-07-13 08:28, Greg Kroah-Hartman wrote:
On Wed, Jul 10, 2013 at 10:23:57PM -0700, Guenter Roeck wrote:
On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote:
Hi all,

Here's the second iteration of the patchset to add better attribute
group support to the driver core and sysfs.

I've tested these (shocker!) and everything works fine with them (I'm
sending this from Linus's latest kernel with these 7 on top of it.)

I'd like to send these to Linus for 3.11 unless someone objects.

Oliver, please use this series instead of the last one, it has fixes
that Guenter pointed out that would have crashed your box at boot.
It still crashes, but haven't read back all. I do have some extra helper macro's patch incoming once i make sure it boots.

(it boots but segfaults) give me a few hours to report back.

oliver

changes from v2:
- actually boots
- 7th patch added properly
- added BUS_ATTR, CLASS_ATTR, and DRIVER_ATTR RW and RO macros
to help with converting code to use attributes properly.

Looks good this time. And, yes, it does boot and work, including patch #7.
Feel free to add

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

and if you like

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

to the series.

Thanks for the testing and review, I'll add this when I commit them
sometime next week.

greg k-h


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/