Re: [PATCH V2] pci: exynos: split into two parts such as Synopsyspart and Exynos part

From: Thierry Reding
Date: Thu Jul 11 2013 - 11:41:40 EST


On Thu, Jul 11, 2013 at 02:49:43PM +0900, Jingoo Han wrote:
[...]
> diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
[...]
> obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o
> obj-$(CONFIG_PCIE_DW) += pcie-designware.o
> +obj-$(CONFIG_PCI_EXYNOS) += pcie-exynos.o

I think we should keep these sorted alphabetically. Also Tegra and
Marvell are PCIe controllers but they still use the pci- prefix instead
of pcie-. Perhaps it'd be good to keep consistency here? I initially
chose pci- because from a software point of view it doesn't matter all
that much whether it's PCI or PCIe and because the drivers are part of
the PCI subsystem. However if Exynos now uses the pcie- prefix it makes
it look like Tegra and Marvell are plain old PCI.

Thierry

Attachment: signature.asc
Description: Digital signature