Re: [PATCH 1/1 V2] linux-firmware: Add AMD microcode patch firmwarefiles

[Suravee Suthikulanit]

On 7/10/2013 8:01 PM, Ben Hutchings wrote:
> I've applied this, but:
>
> On Wed, 2013-07-10 at 19:42 -0500, suravee.suthikulpanit@xxxxxxx wrote:
> > From: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >
> > For AMD Families 10h ~ 14h Processors
> > file:   amd-ucode/microcode_amd.bin
> > md5sum: 55ae79b82cbfddcf7142058be3c9ec2d
> >
> > For AMD Family 15h Processors
> > file:   amd-ucode/microcode_amd_fam15h.bin
> > md5sum: 122ac7e56442c2b7c28eb26978b2d57c
> >
> > Version: 07_10_2013
> This is not a suitable version format, as e.g. 01_01_2014 would be a
> later version but will sort earlier.  When dates are used as versions,
> they should be written in ISO 8601 order, yyyy-mm-dd.  Old releases from
> amd64.org were labelled that way.
Ah.  I'll use different format next time.
> Also, the version belongs in WHENCE, so I added this to WHENCE:
>
> Version: 2013-07-10
Thank you for adding this.
> > Signed-off-by: Sherry Hurwitz <sherry.hurwitz@xxxxxxx>
> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >
> > ---
> >
> > Key Name        = AMD Microcode Signing Key (for signing microcode container files only)
> > Key ID          = 8C0108B4
> > Key Fingerprint = 916A 7708 23A7 B27A ADE0  1565 A5E8 DBC9 8C01 08B4
> >
> > GnuPG Signature for file : microcode_amd.bin.asc
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.11 (GNU/Linux)
> >
> > iQEcBAABAgAGBQJR3dkLAAoJEKXo28mMAQi0/9cIAKraXlbchZkkIPzyMrZBZZJe
> > zapMterpLdDYL6zukfqgF7Frg94+ilGPK9yKAFsvC+EJyHrF5lbRQ/JthANdRv+Y
> > 8sBKz5/knVI72WdjSjg+473I1rFdIUK+YN7Ygp6eAwP3fg/IQ9UD9iQfWKbbUnx0
> > WSEMCZm/izsyU2LQMJvtizJ2gz9ktFoALUtTvj0bv34CKr++qqngEVFy/WKQdR6x
> > R3l5MjFAhvzO0O9gV59s1tXbPU56HRhMbvSBn3NIVZu17pwAFySHwQLAeW10GH0j
> > UfgpKQppbz90iLLaSh8vseTOoTBn5SegDtK0JEJNMOuK1VoZ+kgv0cqGCs17HBQ=
> > =FnHv
> > -----END PGP SIGNATURE-----
> >
> > GnuPG Signature for file : microcode_amd_fam15h.bin.asc
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.11 (GNU/Linux)
> >
> > iQEcBAABAgAGBQJR3dkfAAoJEKXo28mMAQi0iTsIAJ5nCgz/+jFYag2W/OH+kOQe
> > BDXYSC5diXQR5wF/HUkXWh0sl+jNK/OrRVxT7sFaEgAUhEXhK6Df/h7qnJAYQGFr
> > 5+CKhfSr/0Qbk1ziWYAXVKMOXbuLWSSIov1SCcwLsps7A7puITK6xDemLby7KDGC
> > xCUfKIM/BO6DyFpNhKQ+xJdDi+yVxUKQhbdk/8gY94VdUnVZq3CTK9UStpBuaXu0
> > qJNfhbaU+OzgZmnmLq5+xGsCML1xfbgF6sexVRx7oT/Jv30tm97YQJWR0h4DU7jU
> > zjID8kGtYRVV7+i8jC+jVpFo21yDVUkHUcqtNXXRB/lbOYFAm+UJviAEc4NEdSw=
> > =JaWY
> > -----END PGP SIGNATURE-----
> [...]
>
> I added the detached signatures to the commit as separate files, so that
> distributions and other downstream users can verify the signatures.
> linux-firmware.git itself is not currently being tagged, with or without
> signatures.  Please include detached signatures in future.
>
> Ben.
We will do so.

Thank you,
Suravee


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/