Re: [PATCH] fnic: use simple_open instead of fnic_trace_ctrl_open

[Hiral Patel (hiralpat)]

On 7/11/13 11:50 PM, "Camelia Groza" <camelia.groza@xxxxxxxxx> wrote:

>This removes the open coded fnic_trace_ctrl_open() function
>and replaces file operations references to the function
>with simple_open() instead.
>
>Found using coccinelle.
>
>Signed-off-by: Camelia Groza <camelia.groza@xxxxxxxxx>
>---
> drivers/scsi/fnic/fnic_debugfs.c |   19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
>diff --git a/drivers/scsi/fnic/fnic_debugfs.c
>b/drivers/scsi/fnic/fnic_debugfs.c
>index cbcb012..ddc7e94 100644
>--- a/drivers/scsi/fnic/fnic_debugfs.c
>+++ b/drivers/scsi/fnic/fnic_debugfs.c
>@@ -25,23 +25,6 @@ static struct dentry *fnic_trace_debugfs_file;
> static struct dentry *fnic_trace_enable;
> 
> /*
>- * fnic_trace_ctrl_open - Open the trace_enable file
>- * @inode: The inode pointer.
>- * @file: The file pointer to attach the trace enable/disable flag.
>- *
>- * Description:
>- * This routine opens a debugsfs file trace_enable.
>- *
>- * Returns:
>- * This function returns zero if successful.
>- */
>-static int fnic_trace_ctrl_open(struct inode *inode, struct file *filp)
>-{
>-	filp->private_data = inode->i_private;
>-	return 0;
>-}
>-
>-/*
>  * fnic_trace_ctrl_read - Read a trace_enable debugfs file
>  * @filp: The file pointer to read from.
>  * @ubuf: The buffer to copy the data to.
>@@ -222,7 +205,7 @@ static int fnic_trace_debugfs_release(struct inode
>*inode,
> 
> static const struct file_operations fnic_trace_ctrl_fops = {
> 	.owner = THIS_MODULE,
>-	.open = fnic_trace_ctrl_open,
>+	.open = simple_open,
> 	.read = fnic_trace_ctrl_read,
> 	.write = fnic_trace_ctrl_write,
> };
>-- 
>1.7.10.4

Acked-by: Hiral Patel <hiralpat@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/