Re: [PATCH RFC V10 18/18] kvm hypervisor: Add directed yield in vcpublock path

[Raghavendra K T]

On 07/14/2013 07:48 PM, Gleb Natapov wrote:
> On Mon, Jun 24, 2013 at 06:14:15PM +0530, Raghavendra K T wrote:
> > kvm hypervisor: Add directed yield in vcpu block path
> >
> > From: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
> >
> > We use the improved PLE handler logic in vcpu block patch for
> > scheduling rather than plain schedule, so that we can make
> > intelligent decisions.
> What kind of improvement this provides? Doesn't it screw up our pause
> exit heuristics?

No. it does not affect negatively from what I saw. ( and even from
results).

So it will make ple handler to avoid yield_to to those vcpus,
still looping in  halt handler.
May be vcpus which are pv_unhalted but not running, may miss this.
but haven't seen anything bad happening with that.
But yes, planning to do some experiments around this. Thanks for
bringing this up.

Between another good point about this is, though non PLE hardwares are
becoming obsolete, they can potentially take the advantage of PLE
handler.

> > Signed-off-by: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
> > ---
> >   arch/ia64/include/asm/kvm_host.h    |    5 +++++
> >   arch/powerpc/include/asm/kvm_host.h |    5 +++++
> >   arch/s390/include/asm/kvm_host.h    |    5 +++++
> >   arch/x86/include/asm/kvm_host.h     |    2 +-
> >   arch/x86/kvm/x86.c                  |    8 ++++++++
> >   include/linux/kvm_host.h            |    2 +-
> >   virt/kvm/kvm_main.c                 |    6 ++++--
> This miss some arches.

Thanks for pointing that. arm and mips were not around at V8 time, I 
missed them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/