[PATCH] RDMA/cma: silence GCC warning
From: Paul Bolle
Date: Mon Jul 15 2013 - 07:04:09 EST
Building cma.o triggers this GCC warning:
drivers/infiniband/core/cma.c: In function ârdma_resolve_addrâ:
drivers/infiniband/core/cma.c:465:23: warning: âportâ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/infiniband/core/cma.c:426:5: note: âportâ was declared here
This is a false positive, as "port" will always be initialized if we're
at "found".
Help GCC by initializing "port" to 0. Since valid port numbers
apparently start at 1, this is an invalid value. That could help in
analyzing the code and tracking down errors.
Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
---
0) Compile tested only.
1) Perhaps a better way to silence GCC is to drop "port" entirely, and
assign to "id_priv->id.port_num" directly. Would that be acceptable?
drivers/infiniband/core/cma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f1c279f..c6c0a5f 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -426,6 +426,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)
u8 port, p;
int i;
+ port = 0; /* silence GCC */
cma_dev = NULL;
addr = (struct sockaddr_ib *) cma_dst_addr(id_priv);
dgid = (union ib_gid *) &addr->sib_addr;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/