Re: [PATCH-v2 06/17] staging/lustre: remove HIPQUAD

[Peng Tao]

On Mon, Jul 15, 2013 at 9:38 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2013-07-15 at 21:08 +0800, Peng Tao wrote:
> []
>> We should just remove HIPQUAD and replace it with %pI4.
>
> HIPQUAD and NIPQUAD were host and network order variants.
> Perhaps you need %pI4h for the host uses?
>
Thanks for pointing it out. Yes, you are right. Without the additional
specifier, network order is used. I will update the patch to fix it.

Thanks,
Tao

>> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> []
>> @@ -2574,8 +2574,8 @@ kiblnd_dev_need_failover(kib_dev_t *dev)
>>       rc = rdma_resolve_addr(cmid, (struct sockaddr *)&srcaddr,
>>                              (struct sockaddr *)&dstaddr, 1);
>>       if (rc != 0 || cmid->device == NULL) {
>> -             CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
>> -                    dev->ibd_ifname, HIPQUAD(dev->ibd_ifip),
>> +             CERROR("Failed to bind %s:%pI4 to device(%p): %d\n",
>> +                    dev->ibd_ifname, &dev->ibd_ifip,
>>                      cmid->device, rc);
>
> Like this one?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/