Re: [PATCH] kernel: trace: remove __init fromrace_selftest_startup_function() and trace_selftest_startup_function_graph()

[Steven Rostedt]

On Mon, 2013-07-15 at 10:12 +0800, Chen Gang wrote:

> Hello Frederic and Ingo:

Are you trying to go around me? I wrote this code and I'm one of the
maintainers for it. Your issue is very minor, and can wait till other
things get done first.

You said my previous patch fixed your problem, right? Then I'll add your
tested by and push it in due course.

I'll also get around to adding __init's to other functions too. But it
is *very* low on the totem pole of importance.

> 
> Could you provide your suggestions or completions for it ?
> 
> The trace_selftest_startup_* funcitons are mostly added by you without
> '__init', do you have additional considerations about it (intend to have
> no '__init') ?
> 
> If no reply, I recommend to keep no '__init': apply this patch or
> regress part of the patch "f1ed7c7 ftrace: Do not run selftest if
> command line parameter is set" (at least, it can avoid related warnings
> and treat all *selftest* fair).

It's a compile time warning that's a false positive. Not a run time
crash or other issue of importance. It can wait, relax. Otherwise you
are starting to become annoying.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/