Re: [PATCH] usb: udc: add gadget state kobject uevent

[Greg KH]

On Mon, Jul 15, 2013 at 11:57:24AM +0800, Rong Wang wrote:
>     usb: udc: add gadget state kobject uevent
> 
>     Add USB_UDC_STATE environment variable in udc uevent
>     callback and trigger kobject_uevent in usb_gadget_set_state
>     to inform the user-space the state of the gadget.

Why?

And what's with the indentation?

>     Signed-off-by: Rong Wang <Rong.Wang@xxxxxxx>
> 
> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
> index ffd8fa5..05715d1 100644
> --- a/drivers/usb/gadget/udc-core.c
> +++ b/drivers/usb/gadget/udc-core.c
> @@ -101,11 +101,32 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> 
>  /* ------------------------------------------------------------------------- */
> 
> +/**
> + * usb_gadget_set_state - set usb gadget state
> + * @gadget: gadget device
> + * @state: state defined in USB specification ch9
> + * Context: !in_interrupt()
> + */
>  void usb_gadget_set_state(struct usb_gadget *gadget,
>                 enum usb_device_state state)
>  {
> +       struct usb_udc          *udc = NULL;
> +
>         gadget->state = state;
>         sysfs_notify(&gadget->dev.kobj, NULL, "status");
> +
> +       mutex_lock(&udc_lock);
> +       list_for_each_entry(udc, &udc_list, list)
> +               if (udc->gadget == gadget)
> +                       goto found;
> +
> +       dev_err(gadget->dev.parent, "gadget not registered.\n");
> +       mutex_unlock(&udc_lock);
> +       return;
> +
> +found:
> +       mutex_unlock(&udc_lock);
> +       kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE);

I really don't like adding kobject change events, as they usually never
get listened to, and there are other ways to get this information from
userspace, right?

Why do you need/want this?  What is it going to be used for?  What tools
will use it?  How will they use it?

And why can't the existing notification events for gadget devices work
for you?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/