Re: [PATCH 1/2] list: add list_del_each_entry

From: JÃrn Engel
Date: Mon Jul 15 2013 - 15:06:37 EST


On Fri, 5 July 2013 23:38:01 +0100, Filipe David Manana wrote:
>
> > +#define list_del_each_entry(pos, head, member) \
> > + while (list_empty(head) && (pos = list_first_entry((head), \
> > + typeof(*pos), member), list_del((head)->next), 1))
> > +
>
> Shouldn't it be while (!list_empty(head) ... ?
> (not operator addition)

Obviously! Now where is that brown paperbag...

Will resend in a few days, including the _init variants dchinner asked
for.

JÃrn

--
Computer system analysis is like child-rearing; you can do grievous damage,
but you cannot ensure success."
-- Tom DeMarco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/