Re: v3.11-rc1 USB regressions

[Daniel Mack]

This is a multi-part message in MIME format.Hi Aaro,

On 16.07.2013 00:56, Aaro Koskinen wrote:
> Hi,
> 
> I think USB tree introduced regressions in v3.11-rc1, at least for some
> OMAP devices using legacy boot.

Thanks for checking the tree so early.

> I have only bisected these; I have no
> idea what the real fixes are but the following reverts make Nokia OMAP2+
> boards again usable for kernel development work (they need working USB
> connection for interacting with the device):
> 
> 1) USB peripheral mode (g_ether) is broken on Nokia N900, N950 and N9
>    (USB_MUSB_OMAP2PLUS). To make it it work, I need to revert three
>    commits:
> 
> 	09fc7d22b024692b2fe8a943b246de1af307132b
> 	usb: musb: fix incorrect usage of resource pointer
> 	(Reverting this fixes the g_ether probe failure "couldn't find
> 	 an available UDC")

Can't say much about this one, but I'd like you to only keep this one
reverted and sort out the regressions in the musb core first.

> 	fe4cb0912f8e737f8e4b8b38b9e692f8062f5423
> 	usb: musb: gadget: remove hcd initialization
> 	(Reverting this fixes error "cdc_ether: probe of 4-1:1.0 failed
> 	 with error -110" seen on the host side.)

Which role does your musb-based hardware have in this case, and which
MUSB_* config symbols do you set? You should have USB_MUSB_GADGET.

> 	8b125df5b24cfb0ec7fa1971e343cc0badc1827d
> 	usb: musb: eliminate musb_to_hcd	
> 	(Reverting this fixes compilation error cause by the previous
> 	 revert.)
>
> 2) USB peripheral mode (g_ether) is broken also on Nokia N800 and N810
>    (USB_MUSB_TUSB6010). In addition to the above, I need to also revert
>    the following:
> 
> 	b7e2e75a8c6062afe1dd88b0b299938e5d36dff8
> 	usb: gadget: drop unused USB_GADGET_MUSB_HDRC
> 
>    (This commit is clearly incorrect - code checking for this still
>    remain in the tree (see e.g. N8x0 board file), so it's not "unused".)

Good catch, I didn't expect board files to depend on config symbols that
have no effect on the driver itself.

Please check the attached patch and let me know if it helps.


Thanks,
Daniel