Re: [PATCH 13/15] kconfig/[mn]conf: make it explicit in the searchbox that a regexp is possible

[Jean Delvare]

Hi Yann,

Le Monday 08 July 2013 Ã 19:37 +0200, Yann E. MORIN a Ãcrit :
> Jean, All,
> 
> On 2013-07-08 13:25 +0200, Jean Delvare spake thusly:
> > Le Monday 24 June 2013 Ã 20:11 +0200, Yann E. MORIN a Ãcrit :
> > > From: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> > > 
> > > Reported-by: Jean Delvare <jdelvare@xxxxxxx>
> > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> > > Cc: Jean Delvare <jdelvare@xxxxxxx>
> > > Cc: Michal Marek <mmarek@xxxxxxx>
> > > ---
> > >  scripts/kconfig/mconf.c | 2 +-
> > >  scripts/kconfig/nconf.c | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> > > index 6ee4aae..18d3dc9 100644
> > > --- a/scripts/kconfig/mconf.c
> > > +++ b/scripts/kconfig/mconf.c
> > > @@ -401,7 +401,7 @@ static void search_conf(void)
> > >  	struct subtitle_part stpart;
> > >  
> > >  	title = str_new();
> > > -	str_printf( &title, _("Enter %s (sub)string to search for "
> > > +	str_printf( &title, _("Enter %s (sub)string or regexp to search for "
> > >  			      "(with or without \"%s\")"), CONFIG_, CONFIG_);
> > 
> > While clearer, this also makes the title span over two lines when it
> > used to fit on a single one. I would like to suggest the following:
> > 
> > 	str_printf(&title, _("Enter (sub)string or regexp to search for "
> > 			     "(with or without \"%s\")"), CONFIG_);
> > 
> > Rationale: the "(with or without CONFIG_)" makes things clear enough
> > IMHO, making the first occurrence redundant.
> 
> OK, I'll send another patch with the text updated with your suggestion.

Did you? I can't remember seeing it.

-- 
Jean Delvare
Suse L3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/