Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

[Laurent Pinchart]

Hi Prabhakar,

On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
> 
> This patch series replaces existing resource handling in the
> driver with managed device resource.

Thank you for the patches. They greatly simplify the probe/remove functions, I 
like that. For patches 1 to 4,

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

I have the same concern as Joe Perches for patch 5.

> Lad, Prabhakar (5):
>   media: davinci: vpbe_venc: convert to devm_* api
>   media: davinci: vpbe_osd: convert to devm_* api
>   media: davinci: vpbe_display: convert to devm* api
>   media: davinci: vpss: convert to devm* api
>   media: davinci: vpbe: Replace printk with dev_*
> 
>  drivers/media/platform/davinci/vpbe.c         |    6 +-
>  drivers/media/platform/davinci/vpbe_display.c |   23 ++----
>  drivers/media/platform/davinci/vpbe_osd.c     |   45 +++---------
>  drivers/media/platform/davinci/vpbe_venc.c    |   97  ++++-----------------
>  drivers/media/platform/davinci/vpss.c         |   62 ++++------------
>  5 files changed, 52 insertions(+), 181 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/