Re: [PATCH 01/21] MFD: ti_tscadc: disable TSC control

From: Greg KH
Date: Wed Jul 17 2013 - 13:49:47 EST


On Wed, Jul 17, 2013 at 06:26:30PM +0100, Zubair Lutfullah wrote:
> Register bits when TSC not in use

What does this mean?

> AFE Pen Ctrl and TouchScreen transistors enabling is not
>
> required when only ADC mode is being used, so check for availability of
>
> TSC driver before accessing control register.

What's with the extra newlines?

>
> This patch is based on work in the 3.2 tree by TI
> Original Author is Patil Rachna

If you didn't write this, you need to put the "From: " line for the
correct author/email in the patch, as Documentation/SubmittingPatches
describes so that they can get the correct credit.

> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@xxxxxxxxx>

What happened to Patil's signed-off-by: line?
Same goes for other patches in this series.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/