Re: [RFC PATCH 2/4] tracing: Turn "id"->i_private intocall->event.type

[Oleg Nesterov]

On 07/16, Steven Rostedt wrote:
>
> On Tue, 2013-07-16 at 20:57 +0200, Oleg Nesterov wrote:
> > ftrace_event_id_fops and event_id_read() is overcomplicated.
> >
> > 1. Change event_create_dir() to pass "data = call->event.type"
> >    to debugfs_create_file().
> >
> >    This means that ftrace_event_id_fops doesn't need .open()
> >    and event_id_read() can simply print (int)i_private
> >
> > 2. event_id_read() has no reason to kmalloc "struct trace_seq"
> >    (more than PAGE_SIZE!), it can use a small buffer.
>
> Make #2 a separate patch. You can add it before this one.

OK. I'll extract #2 and re-send.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/