Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

From: Felipe Balbi
Date: Thu Jul 18 2013 - 04:08:40 EST


Hi,

On Wed, Jul 17, 2013 at 06:26:34PM +0100, Zubair Lutfullah wrote:
> Main patch. Adds continuous sampling support for the driver
>
> The IRQs are changed in the TSC drivers as they are shared with
> the ADC IRQ lines.
>
> This patch is based on work in the 3.2 tree by TI
> Original Author is Patil Rachna
>
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@xxxxxxxxx>

to me this patch looks incorrect. IIO framework provides a generic ring
buffer implementation which could be used for continuous mode. Adding
driver specific attributes isn't very nice IMO.

--
balbi

Attachment: signature.asc
Description: Digital signature