Re: [PATCH 1/1] kconfig: allow "hex" and "range" to support longs

[Geert Uytterhoeven]

On Sat, Jun 29, 2013 at 4:21 PM, Yann E. MORIN <yann.morin.1998@xxxxxxx> wrote:
> From: Kees Cook <keescook@xxxxxxxxxxxx>
>
> The parsing routines for Kconfig files use strtol(), but store and
> render values as int. Switch types and formating to long to support a
> wider range of values. For example, 0x80000000 wasn't representable.

0x80000000 does fit in an int. If it's printed as hex, it's treated as unsigned.
Is there a "0" missing, or am I missing something?

> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Tested-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> ---
>  scripts/kconfig/symbol.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> index 387d554..d550300 100644
> --- a/scripts/kconfig/symbol.c
> +++ b/scripts/kconfig/symbol.c
> @@ -136,7 +136,7 @@ static struct property *sym_get_range_prop(struct symbol *sym)
>         return NULL;
>  }
>
> -static int sym_get_range_val(struct symbol *sym, int base)
> +static long sym_get_range_val(struct symbol *sym, int base)
>  {
>         sym_calc_value(sym);
>         switch (sym->type) {

Changing all these "int" to "long" only matters on 64-bit platforms.
As kconfig is built on the host, this will cause different behavior when
cross-compiling 64-bit (I assume that's where you need it most) kernels
on a 32-bit or a 64-bit host.

Probably you wanted to use "long long" instead of "long", and switch
to "strtoll()", to make them always 64-bit?

Still, beware using 64-bit config symbols with arithmetic shell operations from
a Makefile, cfr. https://lkml.org/lkml/2013/6/13/200.

Sorry for only noticing now, after it went into 3.11-rc1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/