Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree

[Grygorii Strashko]

On 07/19/2013 05:39 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-07-2013 13:27, Oleksandr Kozaruk wrote:
>
> > GPADC is the general purpose ADC present on twl6030.
> > The dt data is interrupt used to trigger end of ADC
> > conversion.
>
> > Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@xxxxxx>
> > ---
> >   arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
> >   1 file changed, 6 insertions(+)
>
> > diff --git a/arch/arm/boot/dts/twl6030.dtsi
> > b/arch/arm/boot/dts/twl6030.dtsi
> > index 2e3bd31..d7d4c28 100644
> > --- a/arch/arm/boot/dts/twl6030.dtsi
> > +++ b/arch/arm/boot/dts/twl6030.dtsi
> > @@ -103,4 +103,10 @@
> >           compatible = "ti,twl6030-pwmled";
> >           #pwm-cells = <2>;
> >       };
> > +
> > +    adc: gpadc {
>
>     Read my lips: the node should be called just "adc", not "gpadc".
      ^^^^^^^^^^^^ Are you sure?

Why? The name was selected according to the documentation on device 
"General purpose analog-to-digital converter (GPADC)".

PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P

> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Regards,
- grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/