Re: [RESEND][PATCH] mm: vmstats: tlb flush counters

[Dave Hansen]

On 07/19/2013 01:28 AM, Ingo Molnar wrote:
> UP is slowly going extinct, but in any case these counters ought to inform 
> us about TLB flushes even on UP systems:
> 
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ALL,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE_KERNEL,
> While these ought to be compiled out on UP kernels:
> 
>>>> > > > +		NR_TLB_REMOTE_FLUSH,	/* cpu tried to flush others' tlbs */
>>>> > > > +		NR_TLB_REMOTE_FLUSH_RECEIVED,/* cpu received ipi for flush */
> Right?

Yeah, it's useful on UP too.  But I realized that my changes were
confined to the SMP code.  The UP code is almost all in one of the
headers, and I didn't touch it.  So I've got some work there to fix it up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/