Re: [PATCH v2] gpio: add GPIO support for F71882FG and F71889F

[Linus Walleij]

On Wed, Jul 17, 2013 at 12:00 PM, Simon Guinot
<simon.guinot@xxxxxxxxxxxx> wrote:

> This patch adds support for the GPIOs found on the Fintek super-I/O
> chips F71882FG and F71889F.
>
> A super-I/O is a legacy I/O controller embedded on x86 motherboards. It
> is used to connect the low-bandwidth devices. Among others functions the
> F71882FG/F71889F provides: a parallel port, two serial ports, a keyboard
> controller, an hardware monitoring controller and some GPIO pins.
>
> Note that this super-I/Os are embedded on some Atom-based LaCie NASes.
> The GPIOs are used to control the LEDs and the hard drive power.
>
> Signed-off-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx>
> ---
> Linus, I am waiting for your feedback about the Super-I/O device
> detection. Then this part is unchanged since the previous version.
> Else I think I have addressed your other concerns.
>
> Changes since v1:
> - Enhance the commit message by describing what is a Super-I/O.
> - Use self-explanatory names for the GPIO register macros.
> - Add a comment to explain the platform device and driver registration.
> - Fix gpio_get when GPIO is configured in input mode. I only had
>   the hardware to check this mode recently...

This is mostly fine.

> +static int f7188x_gpio_probe(struct platform_device *pdev)
> +{
(...)
> +       platform_set_drvdata(pdev, data);
(...)
> +       platform_set_drvdata(pdev, NULL);
(...)
> +static int f7188x_gpio_remove(struct platform_device *pdev)
(...)
> +       platform_set_drvdata(pdev, NULL);

We don't need to set drvdata to NULL I think, there were
lots of patches addressing this last merge window by Jingoo Han,
see e.g. commit 1cdd8d52ecbedbce1cbac063aa5715810a228ab3
so please get rid of the NULL setters.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/