Re: [PATCH -tip 3/3] x86: Remove unused text_poke_smp andtext_poke_smp_batch

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> 
> * Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
> 
> > Since introducing the text_poke_bp for all text_poke_smp*
> > callers, text_poke_smp* are now unused. This basically
> > reverts 3d55cc8a, 7deb18dc and related commits.
> > 
> > This also fixes a Kconfig dependency issue on STOP_MACHINE
> > in the case of CONFIG_SMP && !CONFIG_MODULE_UNLOAD.
> > 
> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > ---
> >  arch/x86/Kconfig                   |    5 --
> >  arch/x86/include/asm/alternative.h |   11 ----
> >  arch/x86/kernel/alternative.c      |   98 +-----------------------------------
> >  3 files changed, 2 insertions(+), 112 deletions(-)
> 
> Hm, it does not build with the attached config:
> 
> arch/x86/kernel/kprobes/opt.c: In function 'setup_optimize_kprobe':
> arch/x86/kernel/kprobes/opt.c:394:6: error: dereferencing pointer to incomplete type
> arch/x86/kernel/kprobes/opt.c:395:6: error: dereferencing pointer to incomplete type
> arch/x86/kernel/kprobes/opt.c:396:6: error: dereferencing pointer to incomplete type

32-bit appears to be the key pattern.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/