Re: Linux 3.11-rc2

From: Rafael J. Wysocki
Date: Mon Jul 22 2013 - 08:52:26 EST


On Monday, July 22, 2013 12:08:40 AM James Hogan wrote:
> On 21 July 2013 20:53, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > (b) we had a late change to how ACPI backlight handling is done on
> > certain machines, and while this kind of thing really shouldn't be
> > done outside the merge window, I ended up pulling it anyway. But I'd
> > *really* like to have people test this thing particularly on laptops
> > with intel-based graphics. It should only matter (and hopefully
> > improve things) for the newer ones with BIOSes designed for Windows 8,
> > but hey, the more testing, the better. Backlight handling has beenin
> > painful before, so I'm mentioning this explicitly.
>
> 8c5bd7a "ACPI / video / i915: No ACPI backlight if firmware expects
> Windows 8" breaks backlight control for me because
> /sys/class/backlight/acpi_video0 disappears, and
> /sys/class/backlight/intel_backlight doesn't seem to have any effect.
>
> Note that acpi_video0 only worked because I was applying "[PATCH]
> drm/i915: quirk no PCH_PWM_ENABLE for Dell XPS13 backlight" [1], so
> strictly speaking mainline already didn't work.

James, sorry for breaking things for you. The patch you're mentioning is going
to hit the mainline at one point anyway I suppose.

In the meantime I received a report from Steven Newbury that these changes
broke things for him too, so we need to revert commits 8c5bd7a and efaa14c.
The other two commits in the series should be benign.

Linus, do you want me to send a pull request reverting 8c5bd7a and efaa14c?

Rafael (who's having a particularly bad day today)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/