Re: [PATCH -v2] RTC: Add an alarm disable quirk

[Borislav Petkov]

On Mon, Jul 22, 2013 at 02:00:42PM -0700, John Stultz wrote:
> Also, just to clarify, on the affected machines, with this patch,
> wake-up alarm's will in effect be disabled, right?

See below.

> >@@ -385,6 +418,9 @@ static int cmos_alarm_irq_enable(struct device *dev, unsigned int enabled)
> >  	if (!is_valid_irq(cmos->irq))
> >  		return -EINVAL;
> >+	if (!disable_alarm)
> >+		return 0;
> >+
> 
> Did you want this in cmos_alarm_irq_enable? Or cmos_irq_disable?

You're right - the first version did call it only in rtc_alarm_disable()
so I should move it to cmos_alarm_disable(). Will fix.

Btw, I did some more runs on the weekend. It seems, the setting of the
alarm interrupt bit in RTC_CONTROL doesn't matter. I dumped its contents
on shutdown and I had cases where it was 0x22 (bit 5 set) and 0x2.

So my hunch currently is us *not* disabling the alarm, doesn't make it
reboot the box.

I know, unfortunately this is still a brown paper bag and I don't have a
real rootcause...

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/