Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

[Tejun Heo]

Hello, Xiaotian.

Thanks for the fix.  A couple comments below.

On Wed, Jul 17, 2013 at 02:10:39PM +0800, Xiaotian Feng wrote:
>  	for (i = 0; i < host->n_ports; i++) {
>  		struct ahci_port_priv *pp = host->ports[i]->private_data;
> +		const char *desc;
>  
> +		if (ata_port_is_dummy(host->ports[i]))
> +			desc = dev_driver_string(host->dev);
> +		else
> +			desc = pp->irq_desc;

I think it'd be better to branch on pp.  ie. do "if (pp) desc =
pp->... " instead and then add a comment saying "pp is NULL for
dummies".

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/