Re: [PATCH v2 04/15] DMA: shdma: make a pointer const

From: Laurent Pinchart
Date: Mon Jul 22 2013 - 19:36:22 EST


Hi Guennadi,

On Monday 22 July 2013 09:53:51 Guennadi Liakhovetski wrote:
> On Sun, 21 Jul 2013, Laurent Pinchart wrote:
> > On Friday 19 July 2013 18:29:29 Guennadi Liakhovetski wrote:
> > > Platform data shouldn't be changed at run-time, so, pointers to it
> > > should be const.
> >
> > If you move this patch to the beginning of the series you could make the
> > pdata structures const in 02/15 and 03/15.
>
> Are these actually related? I think they can be made const regardless?

Right, the compiler will probably not complain, as the platform data pointer
introduced by patches 02 and 03 are cast to an unsigned long.

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/