Re: Checkpatch error on trace events macros

[Li Zefan]

On 2013/7/30 3:52, Sarah Sharp wrote:
> Hi Andy and Joe,
> 
> Checkpatch is complaining when code adds new trace events macros:
> 
> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> Applying: xhci: add traces for debug messages in xhci_address_device()
> ERROR: Macros with complex values should be enclosed in parenthesis
> #86: FILE: drivers/usb/host/xhci-trace.h:15:
> +#define TRACE_SYSTEM xhci-hcd
> 
> ERROR: Macros with complex values should be enclosed in parenthesis
> #115: FILE: drivers/usb/host/xhci-trace.h:44:
> +#define TRACE_INCLUDE_PATH .
> 
> ERROR: Macros with complex values should be enclosed in parenthesis
> #118: FILE: drivers/usb/host/xhci-trace.h:47:
> +#define TRACE_INCLUDE_FILE xhci-trace
> 
> total: 3 errors, 0 warnings, 169 lines checked
> 
> 
> The macros have to be defined that way for trace events to work.

yeah, that's true, and we always just ignore chechpatch complaints
when it comes to TRACE_EVENT macros.

> Can you fix checkpatch not to complain about trace event macros?
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/