Re: [PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps

[Greg Kroah-Hartman]

On Tue, Jul 30, 2013 at 09:52:39AM +0200, Uwe Kleine-König wrote:
> [expanding Cc: to also include akpm and linux-mm]
> 
> Hello,
> 
> On Mon, Jul 29, 2013 at 01:09:14PM -0700, Greg Kroah-Hartman wrote:
> > On Sun, Jul 28, 2013 at 12:09:37AM +0200, Uwe Kleine-König wrote:
> > > This makes it possible to let gdb access mappings of the process that is
> > > being debugged.
> > > 
> > > uio_mmap_logical was moved and uio_vm_ops renamed to group related code
> > > and differentiate to new stuff.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > ---
> > > Changes since v1:
> > >     - only use generic_access_phys ifdef CONFIG_HAVE_IOREMAP_PROT
> > >     - fix all users of renamed struct
> > 
> > I still get a build error with this patch:
> > 
> >   MODPOST 384 modules
> > ERROR: "generic_access_phys" [drivers/uio/uio.ko] undefined!
> > 
> > So something isn't quite right.
> Ah, you built as a module and generic_access_phys isn't exported. The
> other users of generic_access_phys (arch/x86/pci/i386.c and
> drivers/char/mem.c) can only be builtin.
> 
> So the IMHO best option is to add an EXPORT_SYMBOL(generic_access_phys)
> to mm/memory.c.

EXPORT_SYMBOL_GPL() perhaps?

And why all of a sudden does the uio driver need this change?  It is
working just fine right now without it, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/