Re: [PATCH 2/2] chipidea: Use devm_request_irq()

From: Tejun Heo
Date: Wed Jul 31 2013 - 09:42:26 EST


Hello,

On Wed, Jul 31, 2013 at 02:27:08PM +0100, Mark Brown wrote:
> It's really only interrupts that affect most devices - if there's DMA or
> anything going on after the remove() then as you said earlier the driver
> is probably doing something wrong.

Hmmm... it depends on the specific driver is converted but if the
deactivation sequence - shutting down of command engine - is also
handled by devm as in libata and if you have non-devres resource free
in the exit path, you have the same problem. Again, in general,
tearing things down in the order which isn't the reverse of allocation
is a bad idea. Adhering to the order isn't that hard and will result
in far less craziness in the long term.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/