Re: [PATCH v2 1/1] mfd: palmas: Add power off control

[Stephen Warren]

On 07/31/2013 05:57 AM, Nishanth Menon wrote:
> On 07/31/2013 02:17 AM, Bill Huang wrote:
>> Hook up "pm_power_off" to palmas power off routine if there is DT
>> property "ti,system-power-controller" defined, so platform which is
>> powered by this regulator can be powered off properly.
>>
>> Based on work by:
>> Mallikarjun Kasoju <mkasoju@xxxxxxxxxx>
>>
>> Signed-off-by: Bill Huang <bilhuang@xxxxxxxxxx>
>> cc: Mallikarjun Kasoju <mkasoju@xxxxxxxxxx>
>> ---
>>   .../devicetree/bindings/regulator/palmas-pmic.txt  |    5 +++
>>   drivers/mfd/palmas.c                               |   33
>> ++++++++++++++++++--
> 
> Since the specific question on v1 was not answered, I will ask again,
> any reason why it wont fit in drivers/power/reset/ is'nt it the right
> place to add this?

I think it makes sense to put simple standalone reset drivers into
drivers/power/reset. However, where reset is just one tiny function of a
larger device that already has a driver, it's fine for one driver to
implement multiple features or essentially expose multiple subsystems.

(besides this is system power off not system reset; which is
drivers/power/reset?)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/