Re: [PATCH] checkpatch: Warn when using extern with functionprototypes in .h files

[Arend van Spriel]

On 08/01/2013 02:21 PM, David Howells wrote:
> Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > Using the extern keyword on function prototypes is superfluous
> > visual noise so suggest removing it.
> >
> > Using extern can cause unnecessary line wrapping at 80 columns
> > and unnecessarily long multi-line function prototypes.
> >
> > Suggested-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> Nak.
>
> The "extern" makes it much easier to pick out at a glance.

Really? Grouping function prototypes within the header file is much more 
helpful for spotting them.

Regards,
Arend

> Please standardise on there _being_ externs if you must do this.
>
> It's gratuitous change anyway and not worth the churn.
>
> David
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/