Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().

[David Daney]

On 08/08/2013 12:25 PM, Christoph Lameter wrote:
> On Thu, 8 Aug 2013, David Daney wrote:
>
> > I don't know of any bugs currently caused by this unconditional
> > local_irq_enable(), but I want to use this function in MIPS/OCTEON
> > early boot (when we have early_boot_irqs_disabled).  This also makes
> > this function have similar semantics to on_each_cpu() which is good in
> > itself.
>
> smp_call_function_many() wants interrupts enabled.

That's what the comments say, but it isn't actually true.

The usage introduced by the patch is no different than the existing 
usage in on_each_cpu() 30 line up in the file.

David Daney


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/