Re: [PATCH RESEND v2 1/1] mfd: palmas: Add power off control

[Nishanth Menon]

On 08/09/2013 08:01 AM, Bill Huang wrote:
> On Thu, 2013-08-08 at 20:32 +0800, Lee Jones wrote:
> > On Thu, 08 Aug 2013, Bill Huang wrote:
> >
> > > Hook up "pm_power_off" to palmas power off routine if there is DT
> > > property "ti,system-power-controller" defined, so platform which is
> > > powered by this regulator can be powered off properly.
> > >
> > > Signed-off-by: Mallikarjun Kasoju <mkasoju@xxxxxxxxxx>
> > > Signed-off-by: Bill Huang <bilhuang@xxxxxxxxxx>
> > > ---
> > >   .../devicetree/bindings/regulator/palmas-pmic.txt  |    5 +++
> > >   drivers/mfd/palmas.c                               |   33 ++++++++++++++++++--
> > >   include/linux/mfd/palmas.h                         |    1 +
> > >   3 files changed, 37 insertions(+), 2 deletions(-)
> >
> > Was a clear conclusion reached between Nishanth and yourself?
> >
> > As he has strong opinions on this I'd ideally like his Ack before
> > applying the patch.
> Feel free to NACK if you are feeling this can't fit what you would like
> to add, then I'll pass the ball to you for implementing Palmas power off
> since you have already wrote part of the driver (with USB IRQ unmask?).
Apologies on the delay in review. As long as we are ok with not having a 
drivers/power/reset driver, I can buy this as a step #1. USB IRQ unmask 
could go on top of it.

Other than that,
Acked-by: Nishanth Menon <nm@xxxxxx>

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/