Re: [PATCH 3/9] PCI: mvebu: remove subsys_initcall

[Sebastian Hesselbarth]

On 08/13/13 10:06, Thierry Reding wrote:
> On Tue, Aug 13, 2013 at 09:19:59AM +0200, Thomas Petazzoni wrote:
> > On Mon, 12 Aug 2013 20:46:49 +0200, Sebastian Hesselbarth wrote:
> > > This removes the subsys_initcall from the driver and converts it to
> > > a normal platform_driver. Also, drvdata is set and a remove functions
> > > is added to disable the clock and free resources.
> > >
> > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> >
> > I'm OK with this, just a comment below.
> >
> > > +static int mvebu_pcie_remove(struct platform_device *pdev)
> > > +{
> > > +	struct mvebu_pcie *pcie = platform_get_drvdata(pdev);
> > > +	struct mvebu_pcie_port *port = &pcie->ports[0];
> > > +	int i;
> > > +
> > > +	for (i = 0; i < pcie->nports; i++, port++) {
> > > +		clk_disable_unprepare(port->clk);
> > > +		kfree(port->name);
> > > +	}
> > > +
> > > +	return 0;
> > > +}
> >
> > I believe the ->remove() part is quite useless. The driver is a 'bool'
> > in Kconfig, so it cannot be compiled as a module, and I'm not sure
> > there a way to remove the platform device that corresponds to the PCIe
> > controller.
>
> There is. You can write the device's name to the driver's unbind file in
> sysfs. What I ended up doing for Tegra was not to provide a .remove() at
> all and set the struct device_driver's .suppress_bind_attrs to true.
[...]
> That said, I agree with Thomas that it's not useful (and potentially
> even dangerous) to add the .remove() at this point in time.

Thierry, Thomas,

I will not introduce the .remove and set .suppress_bind_attrs = true as
Thierry suggested.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/